Skip to content

Data OMat #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 10, 2025
Merged

Data OMat #1520

merged 3 commits into from
Oct 10, 2025
+481 −4

Conversation

lbluque
Copy link
Contributor

@lbluque lbluque commented Sep 24, 2025 •
edited
Loading

Create a fairchem.data.omat package

  • Add OMat24 VASP input set generators
  • MP2020-style compatibility correction class

@meta-cla meta-cla bot added the cla signed label Sep 24, 2025
@lbluque lbluque added major Major / breaking version release enhancement New feature or request labels Sep 24, 2025
@lbluque lbluque requested a review from zulissimeta September 24, 2025 19:05
zulissimeta
zulissimeta previously approved these changes Sep 24, 2025
View reviewed changes
Copy link
Contributor

@zulissimeta zulissimeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.09%. Comparing base (b94fb1a) to head (4b2a5bb).
⚠️ Report is 25 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1520      +/-   ##
==========================================
+ Coverage   69.44%   70.09%   +0.64%     
==========================================
  Files         131      116      -15     
  Lines       11203     9746    -1457     
==========================================
- Hits         7780     6831     -949     
+ Misses       3423     2915     -508

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jagritisahoo
jagritisahoo approved these changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@jagritisahoo jagritisahoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lbluque lbluque added this pull request to the merge queue Oct 10, 2025
@lbluque lbluque removed this pull request from the merge queue due to a manual request Oct 10, 2025
@lbluque lbluque added this pull request to the merge queue Oct 10, 2025
Merged via the queue into main with commit 2bebf40 Oct 10, 2025
14 checks passed
@lbluque lbluque deleted the data-omat branch October 10, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jagritisahoo jagritisahoo jagritisahoo approved these changes

@zulissimeta zulissimeta zulissimeta left review comments

Assignees

No one assigned

Labels

cla signed enhancement New feature or request major Major / breaking version release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lbluque @codecov-commenter @zulissimeta @jagritisahoo